[SDK] Feature: Track transactions and SIWE #5086
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
packages/thirdweb/src/wallets/in-app/core/wallet/enclave-wallet.ts
Outdated
Show resolved
Hide resolved
joaquim-verges
left a comment
joaquim-verges
left a comment
There was a problem hiding this comment.
Would like to change the tx tracking approach
gregfromstl
force-pushed
the
feat/track-transactions
branch
from
2ae2e90 to
c4b23a7
Compare
size-limit report 📦
|
gregfromstl
requested review from
MananTank,
edwardysun and
jnsdls
as code owners
| */ | ||
| async function trackSiweEvent( | ||
| event: SiweEvent & { | ||
| action: "login:attempt"; |
There was a problem hiding this comment.
i read this as 'the event before verifying any payload' - but really its the login action, and that can be success of failed if theres an error right?
There was a problem hiding this comment.
I thought we wanted a single action label and we'd tell from the error if it succeeded or not?
There was a problem hiding this comment.
yeah, was just thrown off by the 'attempt' label.
would have just called it action: login or action: authenticate since this is not just an attempt but actually a fully succesful/failed login
gregfromstl
force-pushed
the
feat/track-transactions
branch
from
aa9d861 to
ed2a55e
Compare
gregfromstl
force-pushed
the
feat/track-transactions
branch
from
ed2a55e to
508661d
Compare
gregfromstl
added
the
merge-queue
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on improving the analytics tracking for wallet connections and transactions within the `thirdweb` library. It refines the tracking methods by introducing specific tracking functions for connections and payments, enhancing the data sent for analytics.
### Detailed summary
- Deleted `track.ts` file.
- Updated import paths for `trackConnect` and `trackPayEvent` in several files.
- Introduced `trackConnect` and `trackPayEvent` functions with detailed parameters.
- Added tracking functionality to wallet connection methods in `in-app` and `coinbase` wallets.
- Enhanced error handling and data structure in tracking functions.
- Added tests for `trackConnect`, `trackPayEvent`, and `trackLogin` functionalities.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
feat/track-transactions
branch
from
508661d to
4f22e2b
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the tracking functionality in the
thirdwebSDK by refining the analytics tracking methods for wallet connections and transactions, ensuring better data collection and reporting.Detailed summary
trackConnectandtrackPayEventto specific paths.trackConnectandtrackPayEventfunctions with detailed parameters.trackConnect,track,trackPayEvent, andtrackLogin.